chore: better PHP types #4886
Merged
chore: better PHP types #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
chore/php-types
branch
4 times, most recently
from
4ba1fc6 to
ad1eab2
Compare
alanpoulain
force-pushed
the
chore/php-types
branch
2 times, most recently
from
3900a3a to
30b2ed5
Compare
alanpoulain
force-pushed
the
chore/php-types
branch
from
30b2ed5 to
8acee01
Compare
chalasr
reviewed
Aug 11, 2022
| @@ -26,5 +26,5 @@ interface ProcessorInterface | |||
| /** | |||
| * Handle the state. | |||
| */ | |||
| public function process($data, Operation $operation, array $uriVariables = [], array $context = []); | |||
| public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = []); | |||
There was a problem hiding this comment.
Is there any use case for returning something? Or should there be a void return type?
There was a problem hiding this comment.
Yes there is: you return your resource, for instance after a POST to obtain the generated identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.