Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ApiFilter to new format #4845

Merged

Conversation

nawel-les-tilleuls
Copy link
Contributor

Q A
Branch? 2.7
Tickets #...

command to upgrade ApiFilters annotations.

Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please execute php-cs-fixer, and update phpstan.neon.dist file (cf. #4842)

src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix php-cs

src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
src/Core/Upgrade/UpgradeApiFilterVisitor.php Outdated Show resolved Hide resolved
@vincentchalamon vincentchalamon changed the title upgrade filters Migrate ApiFilter to new format Jul 22, 2022
@vincentchalamon vincentchalamon force-pushed the feat/upgrade-filters branch 7 times, most recently from f05f936 to c7f7dcd Compare July 25, 2022 07:41
@vincentchalamon vincentchalamon merged commit 5f4ceb6 into api-platform:2.7 Jul 25, 2022
@vincentchalamon
Copy link
Contributor

Thanks @nawel-les-tilleuls for your first contribution on API Platform 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants