Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-ld): property metadata types and iris #4769

Merged
merged 1 commit into from
May 26, 2022

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented May 21, 2022

No description provided.

@soyuka soyuka force-pushed the fix/jsonld-property-metadata-iris branch 3 times, most recently from e9f4074 to dc3c731 Compare May 23, 2022 18:16
@@ -74,7 +74,7 @@ final class PropertyMetadataCompatibilityTest extends TestCase
'extraProperties' => [
'custom_property' => 'Lorem ipsum dolor sit amet',
],
'iri' => false,
'iris' => ['schema.org/totalPrice'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the scheme missing?

@soyuka soyuka force-pushed the fix/jsonld-property-metadata-iris branch from dc3c731 to 00aecce Compare May 25, 2022 12:56
@soyuka soyuka force-pushed the fix/jsonld-property-metadata-iris branch from 00aecce to 659f213 Compare May 25, 2022 15:52
@soyuka soyuka merged commit 01910f1 into api-platform:2.7 May 26, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 2, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants