-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): output creates its own type in TypeBuilder #4766
Merged
alanpoulain
merged 1 commit into
api-platform:main
from
alanpoulain:fix/graphql-output-dto
May 20, 2022
Merged
fix(graphql): output creates its own type in TypeBuilder #4766
alanpoulain
merged 1 commit into
api-platform:main
from
alanpoulain:fix/graphql-output-dto
May 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alanpoulain
commented
May 20, 2022
•
edited
Loading
edited
Q | A |
---|---|
Branch? | main |
Tickets | Fixes #3155, fixes #3647 |
License | MIT |
Doc PR | Explicit the need to have a DataTransformer and not do it in the resolver |
adf6514
to
e168ab2
Compare
e168ab2
to
74f03bf
Compare
This should've targeted 2.7, or maybe even 2.6. I'm not sure that introducing 2 new DataTransformers (implementing a deprecated interface) is a good idea. |
alanpoulain
added a commit
to alanpoulain/core
that referenced
this pull request
May 21, 2022
alanpoulain
added a commit
to alanpoulain/core
that referenced
this pull request
May 21, 2022
alanpoulain
added a commit
that referenced
this pull request
May 21, 2022
@soyuka, Is the main branch no longer associated with version 2.7? Packagist.org lists this branch as dev-main / 2.7.x-dev |
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 13, 2022
…-platform#4766)" This reverts commit 1f4085e.
soyuka
added a commit
that referenced
this pull request
Jun 14, 2022
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 22, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)" This reverts commit 1f4085e. * fix: resources order
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)" This reverts commit 1f4085e. * fix: resources order
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)" This reverts commit 1f4085e. * fix: resources order
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)" This reverts commit 1f4085e. * fix: resources order
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)" This reverts commit 1f4085e. * fix: resources order
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)" This reverts commit 1f4085e. * fix: resources order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.