Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): output creates its own type in TypeBuilder #4766

Merged
merged 1 commit into from
May 20, 2022

Conversation

alanpoulain
Copy link
Member

@alanpoulain alanpoulain commented May 20, 2022

Q A
Branch? main
Tickets Fixes #3155, fixes #3647
License MIT
Doc PR Explicit the need to have a DataTransformer and not do it in the resolver

@alanpoulain alanpoulain force-pushed the fix/graphql-output-dto branch from adf6514 to e168ab2 Compare May 20, 2022 12:36
@alanpoulain alanpoulain force-pushed the fix/graphql-output-dto branch from e168ab2 to 74f03bf Compare May 20, 2022 13:30
@alanpoulain alanpoulain merged commit 4fe0821 into api-platform:main May 20, 2022
@soyuka
Copy link
Member

soyuka commented May 21, 2022

This should've targeted 2.7, or maybe even 2.6. I'm not sure that introducing 2 new DataTransformers (implementing a deprecated interface) is a good idea.

@lermontex
Copy link

lermontex commented May 21, 2022

@soyuka, Is the main branch no longer associated with version 2.7?

Packagist.org lists this branch as dev-main / 2.7.x-dev

https://s20.directupload.net/images/220521/qq7si96n.png

soyuka added a commit to soyuka/core that referenced this pull request Jun 13, 2022
soyuka added a commit that referenced this pull request Jun 14, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (#4766)"

This reverts commit 1f4085e.

* fix: resources order
soyuka added a commit to soyuka/core that referenced this pull request Jun 22, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)"

This reverts commit 1f4085e.

* fix: resources order
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)"

This reverts commit 1f4085e.

* fix: resources order
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)"

This reverts commit 1f4085e.

* fix: resources order
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)"

This reverts commit 1f4085e.

* fix: resources order
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)"

This reverts commit 1f4085e.

* fix: resources order
soyuka added a commit to soyuka/core that referenced this pull request Jun 29, 2022
* Revert "fix(graphql): output creates its own type in TypeBuilder (api-platform#4766)"

This reverts commit 1f4085e.

* fix: resources order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output DTO in GraphQl schema [GraphQL] Setting "output" on a mutation doesn't work
3 participants