Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change order of mapping paths being loaded #4465

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

tbuczen
Copy link
Contributor

@tbuczen tbuczen commented Sep 23, 2021

Q A
Branch? current stable version branch
Tickets #4464
License MIT

Description of purpose for this PR is written in following issue.

#4464

@tbuczen tbuczen changed the title fix(mapping) Change order of mapping paths being loaded fix: Change order of mapping paths being loaded Sep 23, 2021
@tbuczen tbuczen force-pushed the fix/mapping-paths-load-order branch from 936e4be to bd05d9b Compare September 23, 2021 17:34
@alanpoulain
Copy link
Member

Hello and thanks for your PR.
However it's a duplicate of #3987.
It seems this change is really needed for Sylius, but it's a BC break.
@dunglas @soyuka WDYT? Should we merge it for 2.7 anyway?

@tbuczen
Copy link
Contributor Author

tbuczen commented Sep 24, 2021

Thanks for fast reply and sorry for making a duplicate. I was just searching for similar issues, not PR's

@soyuka
Copy link
Member

soyuka commented Sep 27, 2021

We can merge this for 2.7 I think and it needs a line in the changelog

@alanpoulain alanpoulain force-pushed the fix/mapping-paths-load-order branch from 9d6dc37 to 196bf1c Compare September 27, 2021 15:23
@alanpoulain alanpoulain merged commit 98e4439 into api-platform:main Sep 27, 2021
@alanpoulain
Copy link
Member

Thanks!

vincentchalamon pushed a commit to vincentchalamon/core that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants