Allow defining exception_to_status per operation #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
exception-to-status-per-operation
branch
3 times, most recently
from
0c89695 to
7d8b503
Compare
julienfalque
force-pushed
the
exception-to-status-per-operation
branch
from
7d8b503 to
1aec872
Compare
alanpoulain
force-pushed
the
exception-to-status-per-operation
branch
from
1aec872 to
2b5ab9b
Compare
|
Thank you for your PR! |
|
Sure, see api-platform/docs#1309. |
|
@alanpoulain I updated |
julienfalque
force-pushed
the
exception-to-status-per-operation
branch
2 times, most recently
from
ce4acdb to
7b83475
Compare
alanpoulain
reviewed
Mar 5, 2021
|
Yes, it will be OK like this! |
julienfalque
force-pushed
the
exception-to-status-per-operation
branch
from
7b83475 to
dd746c7
Compare
alanpoulain
force-pushed
the
exception-to-status-per-operation
branch
from
dd746c7 to
3e5ab24
Compare
alanpoulain
approved these changes
Mar 9, 2021
|
Thank you @julienfalque. |
|
Thank you @alanpoulain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows introduces the
exception_to_statusattribute in operations and resources mapping.The use case is when some domain exception should be transformed into a specific HTTP status on some API endpoints, but not on others.
For example: a method in some entity throws a
NotPossibleexception when called through an API endpoint. You want that endpoint to return a400 Bad Request. But if the same entity method throws that exception when called from unrelated internal code, maybe that's actually an error in the code and should result in a500 Internal Server Error.