Improve the RangeFilter DQL query in case the "between" values are equals #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epourail
changed the title
|
I consider this as a bug fix, could you please target 2.5? Thanks! |
epourail
force-pushed
the
feature-improve-between-range-filter
branch
from
1dae1b2 to
d2afb82
Compare
|
@soyuka Done (updated to target 2.5) |
|
|
|
It will just improve the generated query syntax to use a single-comparison operation instead of a two-ways comparison (greater than and less than). |
|
looks like php-cs-fixer needs to be run, make sure to rebase against the latest 2.5 though :) |
epourail
force-pushed
the
feature-improve-between-range-filter
branch
from
ecaa490 to
ceaa59d
Compare
|
thanks @epourail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the behavior of the RangeFilter filter in case the values of the between operator are equals
In such case, the DQL query is defined with the equals operation