Add files to test client #3486
Merged
Add files to test client #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CoalaJoe
commented
Apr 9, 2020
CoalaJoe
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | #3299 |
| License | MIT |
| Doc PR | api-platform/docs#... |
soyuka
reviewed
Apr 9, 2020
| @@ -84,7 +84,7 @@ public function setDefaultOptions(array $defaultOptions): void | |||
| * | |||
| * @return Response | |||
| */ | |||
| public function request(string $method, string $url, array $options = []): ResponseInterface | |||
| public function request(string $method, string $url, array $options = [], array $files = []): ResponseInterface | |||
There was a problem hiding this comment.
We can't change the method signature here as it should respect this interface: https://github.com/symfony/contracts/blob/master/HttpClient/HttpClientInterface.php#L84. Files aren't in the option list, we could maybe support this via the extra key?
There was a problem hiding this comment.
Updated to your suggestion
soyuka
reviewed
Apr 9, 2020
| @@ -121,7 +122,8 @@ public function request(string $method, string $url, array $options = []): Respo | |||
| 'url' => $resolvedUrl, | |||
| 'primary_port' => 'http:' === $url['scheme'] ? 80 : 443, | |||
| ]; | |||
| $this->kernelBrowser->request($method, $resolvedUrl, [], [], $server, $options['body'] ?? null); | |||
| $extra = $options['extra'] ?? []; | |||
| $this->kernelBrowser->request($method, $resolvedUrl, [], $extra['files'] ?? [], $server, $options['body'] ?? null); | |||
There was a problem hiding this comment.
you can use $options['extra']['files'] ?? [] directly here
There was a problem hiding this comment.
I've updated it based on your suggestion
|
Thanks @CoalaJoe we could maybe add some documentation to that in api-platform/docs! |
|
As reported on Slack, this should be backported in 2.5 as it's a bug fix. |
dunglas
pushed a commit
that referenced
this pull request
Sep 15, 2020
* Add files to test client * Respect method signature in favor of interface * Add missing default * Add request parameters to client. Co-authored-by: Ashura <[email protected]>
dunglas
added a commit
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.