Don't typehint the SchemaFactory decorator by its implementation, but by its interface #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhh... Thanks for catching this! I believe it's an unintended mistake. |
|
Rebase needed because I've just merged another PR. Could you take care of it, or would you like me to do it? |
teohhanhui
changed the title
arnedesmedt
force-pushed
the
enableDecoratingSchemaFactory
branch
from
c1d9e0f to
b4aea13
Compare
|
I've rebased it and wrote an if round some JsonSchemaFactory specific code. |
teohhanhui
reviewed
Feb 27, 2020
| $schemaFactory->addDistinctFormat('jsonld'); | ||
|
|
||
| if ($schemaFactory instanceof BaseSchemaFactory) { | ||
| $schemaFactory->addDistinctFormat('jsonld'); |
There was a problem hiding this comment.
This is very weird indeed...
Looks like a design problem to me @dunglas
There was a problem hiding this comment.
@teohhanhui Is it possible to add this and create a new issue to solve the design issue?
teohhanhui
force-pushed
the
enableDecoratingSchemaFactory
branch
from
b4aea13 to
a23a67c
Compare
teohhanhui
changed the title
|
Thanks @arnedesmedt! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable decorating schema factory by it's interface.
The Hydra Json Schema Factory could not be decorated with a custom SchemaFactoryInterface.
The JsonSchemaFactory was used as a default. I've changed the type hint to the interface so everybody can now generate their own SchemaFactory implementations.