Fix a bug preventing to serialize validator's payload #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
fix-validator-payload
branch
from
5e7f0b0 to
e5014d8
Compare
|
Hmm... I'm not familiar with this, but using an empty array to mean "all fields" is so confusing... |
|
I think we should fix the documentation instead. |
dunglas
force-pushed
the
fix-validator-payload
branch
from
e5014d8 to
37a2787
Compare
|
@teohhanhui you're right it's a better solution. Fixed. |
dunglas
force-pushed
the
fix-validator-payload
branch
from
37a2787 to
de6fb15
Compare
dunglas
added a commit
that referenced
this pull request
Apr 21, 2020
* 2.5: Bump versions of Swagger UI, GraphiQL and GraphQL Playground and improve contrib instructions Update changelog Fix a bug preventing to serialize validator's payload (#3375) Ignore FOSUser deprecations only Fix tests (#3506) Stop suggestion FOSUser, it harms more than it helps Changelog for 2.5.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior when dealing with validation error payload (severity etc) isn't in sync with what is expected and documented: https://api-platform.com/docs/core/validation/#error-levels-and-payload-serialization
This PR fixes this problem.