[OpenApi] [Oauth] Fix render oauth when using OpenApi v3 #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibbarth
force-pushed
the
fix/oauth-security-definition-openapi
branch
from
49d7c32 to
5727a1c
Compare
teohhanhui
approved these changes
Jan 2, 2020
teohhanhui
reviewed
Jan 2, 2020
teohhanhui
reviewed
Jan 2, 2020
Jibbarth
commented
Jan 11, 2020
| 'type' => $this->oauthType, | ||
| 'description' => sprintf( | ||
| 'OAuth 2.0 %s Grant', | ||
| strtolower(preg_replace('/[A-Z]/', ' \\0', lcfirst($this->oauthFlow))) |
There was a problem hiding this comment.
Heavily inspired by CamelCaseToSnakeCaseNameConverter
dunglas
approved these changes
Jan 12, 2020
soyuka
force-pushed
the
fix/oauth-security-definition-openapi
branch
from
d05fad2 to
8dccfa3
Compare
|
Thanks @Jibbarth ! |
turegjorup
added a commit
to danskernesdigitalebibliotek/ddb-cover-service-upload
that referenced
this pull request
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the documentation for Oauth in OAS3 (https://swagger.io/docs/specification/authentication/oauth2/), flows now need to be an array.
This fix turn this
in this
I kept the current behaviour for swagger v2.