Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in Router.php match function #3095

Closed
wants to merge 2 commits into from
Closed

Bug in Router.php match function #3095

wants to merge 2 commits into from

Conversation

bpiwowar
Copy link

@bpiwowar bpiwowar commented Sep 26, 2019 •
edited by dunglas
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #3094
License MIT
Doc PR n/a

dunglas
dunglas requested changes Sep 26, 2019
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Could you also add a unit test to prevent regressions please?

composer.json Outdated Show resolved Hide resolved
src/Bridge/Symfony/Routing/Router.php Outdated Show resolved Hide resolved
@bpiwowar bpiwowar requested a review from dunglas September 26, 2019 20:59
@alanpoulain alanpoulain changed the base branch from 2.5 to 2.6 March 23, 2021 09:27
@alanpoulain
Copy link
Member

Superseded by #3776.

@alanpoulain alanpoulain mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
bug [WFC] Waiting for Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bpiwowar @alanpoulain @dunglas @soyuka