Fix Doctrine query for nested subresources #1608
Conversation
alanpoulain
force-pushed
the
fix/recursive-subresources
branch
2 times, most recently
from
fe65701 to
ac17260
Compare
alanpoulain
force-pushed
the
fix/recursive-subresources
branch
from
ac17260 to
3ef7c9e
Compare
| * | ||
| * @ORM\Column(type="integer") | ||
| * @ORM\Id | ||
| * @ORM\GeneratedValue(strategy="AUTO") |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thought strategy="AUTO" was the default value.
There was a problem hiding this comment.
Oh you meant that, OK!
| $previousQueryBuilder = $qb; | ||
| } else { | ||
| $previousQueryBuilder->andWhere($qb->expr()->in($previousAlias, $qb->getDQL())); | ||
| } |
There was a problem hiding this comment.
this is recursive already no? Not sure what was going on wrong here 😸
There was a problem hiding this comment.
No, this was not recursive (despite the comment!).
alanpoulain
force-pushed
the
fix/recursive-subresources
branch
from
15f4dd0 to
3ef7c9e
Compare
| */ | ||
| private function buildQuery(array $identifiers, array $context, QueryNameGenerator $queryNameGenerator, QueryBuilder $previousQueryBuilder, string $previousAlias, int $remainingIdentifiers, QueryBuilder $topQueryBuilder = null): QueryBuilder | ||
| { | ||
| if (!$remainingIdentifiers) { |
There was a problem hiding this comment.
0 < --$remainingIdentifiers then we can avoid -- below and the $remainingIdentifiers - 1 operation?
There was a problem hiding this comment.
I think it's clearer this way. Because if -- is done here it's more the position of the identifier and not the remaining ones. And you have to add the operation $remainingIdentifiers + 1 where there is $remainingIdentifiers. WDYT?
There was a problem hiding this comment.
ok then maybe 0 === $remainingIdentifiers instead of !?
There was a problem hiding this comment.
If you prefer. Then not 0 >= $remainingIdentifiers?
There was a problem hiding this comment.
Or even $remainingIdentifiers <= 0 (I don't really like Yoda style for comparison)?
There was a problem hiding this comment.
Dunno it's fine like this as well.
| $qb->select($joinAlias) | ||
| ->from($identifierResourceClass, $alias) | ||
| ->innerJoin("$alias.$previousAssociationProperty", $joinAlias); | ||
|
|
There was a problem hiding this comment.
for cosmetics, new line is useless here imo \o/
|
Thanks @alanpoulain |
Fix the build of the Doctrine query for subresources nested in more than 2 levels of depth.
Use a recursive function instead of a while loop.