Wrong condition in ParameterExtension #6844
Comments
|
@CvekCoding This issue will be solved in API Platform version |
6 tasks
|
@vinceAmstoutz thanks) |
soyuka
added a commit
to soyuka/core
that referenced
this issue
Dec 8, 2024
|
we should fix this in lower branches |
soyuka
added a commit
that referenced
this issue
Dec 9, 2024
soyuka
added a commit
that referenced
this issue
Dec 13, 2024
* fix(jsonschema): hashmaps produces invalid openapi schema (#6830) * fix(jsonschema): hashmaps produces invalid openapi schema * fix --------- Co-authored-by: soyuka <[email protected]> * fix: add missing error normalizer trait and remove deprecated interface (#6853) * fix: test empty parameter against null (#6852) fixes #6844 * Fix deprecation symfony/dependency-injection * cs: run php-cs-fixer * ci: use problem error normalizer trait * fix(metadata): various parameter improvements (#6867) - `Parameter::getValue()` now takes a default value as argument `getValue(mixed $default = new ParameterNotFound()): mixed` - `Parametes::get(string $key, string $parameterClass = QueryParameter::class)` (but also `has` and `remove`) now has a default value as second argument to `QueryParameter::class` - Constraint violation had the wrong message when using `property`, fixed by using the `key` instead: --------- Co-authored-by: Vincent Amstoutz <[email protected]> Co-authored-by: mladencosa <[email protected]> Co-authored-by: Michiel Kalle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
API Platform version(s) affected: 4
Description
In ParamaterExtension there is an edge case when we pass "0" in an argument value, which is ok for boolean filter for example.
see
core/src/Doctrine/Orm/Extension/ParameterExtension.php
Line 44 in de3bed2
This condition
!($v = $parameter->getValue())skips the parameter for further processing.How to reproduce
Use zero as an argument value.
The text was updated successfully, but these errors were encountered: