Exception when using Ramsey/Uuid ^4.0

[BeyerJC]

API Platform version(s) affected: x.y.z

Description
After updating to Ramsey/Uuid ^4.0 i get an exception when querying an item with identifier. For example api/books/3fa85f64-5717-4562-b3fc-2c963f66afa6

The exception:
Argument 1 passed to Ramsey\Uuid\Uuid::fromString() must be of the type string, object given, called in ..\vendor\api-platform\core\src\Bridge\RamseyUuid\Identifier\Normalizer\UuidNormalizer.php on line 35

$data contains an Uuid object instead of an string , the Uuid is my identifier.

It works fine with Ramsey/Uuid ^3.9 !

Possible Solution
Add a check if $data is a string or an instance of UuidInterface in the UuidNormalizer

[soyuka]

You may not need this normalizer after all, could you trying removing it to see if everything works as expected?

[BeyerJC]

You may not need this normalizer after all, could you trying removing it to see if everything works as expected?

All my GET-Item Operations are working without the Normalizer. My POST test is failing now

Uncaught PHP Exception Symfony\Component\Serializer\Exception\MissingConstructorArgumentsException: "Cannot create an instance of "Ramsey\Uuid\Uuid" from serialized data because its constructor requires parameter "fields" to be present

[soyuka]

My guess is that the denormalizer can't use the Uuid class as-is. Would you be able to add a denormalizer for the Uuid type (see https://symfony.com/doc/current/serializer/custom_normalizer.html#creating-a-new-normalizer) to see if it fixes it.

[BeyerJC]

It works if i adjust the UuidNormalizer with the check i suggested in "Possible solution".
I changed

core/src/Bridge/RamseyUuid/Identifier/Normalizer/UuidNormalizer.php

Line 35 in 6cdf4e0

return Uuid::fromString($data);

to
return ($data instanceof UuidInterface) ? $data : Uuid::fromString($data);

That fixes the problem and should not impact older versions of ramsey.

@soyuka Im not sure what denormalizer i should add. The existing one already supports the UuidInterface. Can you give me a hint ?

[soyuka]

There is a difference between the Identifier normalizer and the denormalizer I suggested. In fact what bother's me is that we already have:

    public function supportsDenormalization($data, $type, $format = null)
    {
        return is_a($type, UuidInterface::class, true);
    }

The code should not go through the denormalize if this isn't true. I'll try some things and come back to you.