fix: item_uri_template conflict with context on relation (#6015)

* fix: item_uri_template conflict with context on relation * test --------- Co-authored-by: soyuka <[email protected]>
api-platform · Dec 19, 2023 · ccf52c1 · ccf52c1
1 parent dcfd3c5
commit ccf52c1
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/features/hydra/item_uri_template.feature b/features/hydra/item_uri_template.feature
@@ -220,3 +220,16 @@ Feature: Exposing a collection of objects should use the specified operation to
         ]
     }
     """
+
+  Scenario: Create an object with an itemUriTemplate should generate the IRI according to the specified itemUriTemplate
+    When I add "Content-Type" header equal to "application/ld+json"
+    And I send a "POST" request to "/issue5662/books/a/reviews" with body:
+    """
+    {
+      "body": "Good book"
+    }
+    """
+    Then the response status code should be 201
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON node "@id" should be equal to "/issue5662/books/a/reviews/0"
diff --git a/src/Serializer/AbstractItemNormalizer.php b/src/Serializer/AbstractItemNormalizer.php
@@ -678,7 +678,7 @@ protected function getAttributeValue(object $object, string $attribute, string $
                 && $this->resourceClassResolver->isResourceClass($className)
             ) {
                 $childContext = $this->createChildContext($this->createOperationContext($context, $className), $attribute, $format);
-                unset($childContext['iri'], $childContext['uri_variables']);
+                unset($childContext['iri'], $childContext['uri_variables'], $childContext['item_uri_template']);
 
                 if ('jsonld' === $format && $uriTemplate = $propertyMetadata->getUriTemplate()) {
                     $operation = $this->resourceMetadataCollectionFactory->create($className)->getOperation(

diff --git a/tests/Fixtures/TestBundle/Entity/Issue5662/Review.php b/tests/Fixtures/TestBundle/Entity/Issue5662/Review.php
@@ -17,6 +17,8 @@
 use ApiPlatform\Metadata\GetCollection;
 use ApiPlatform\Metadata\Link;
 use ApiPlatform\Metadata\Operation;
+use ApiPlatform\Metadata\Post;
+use ApiPlatform\State\CreateProvider;
 
 #[GetCollection(
     uriTemplate: '/issue5662/admin/reviews{._format}',
@@ -43,12 +45,28 @@
         'id' => new Link(fromClass: Review::class),
     ]
 )]
+#[Post(
+    itemUriTemplate: '/issue5662/books/{bookId}/reviews/{id}{._format}',
+    uriTemplate: '/issue5662/books/{id}/reviews{._format}',
+    uriVariables: [
+        'id' => new Link(toProperty: 'book', fromClass: Book::class),
+    ],
+    provider: CreateProvider::class,
+    processor: [Review::class, 'process']
+)]
 class Review
 {
-    public function __construct(public Book $book, public int $id, public string $body)
+    public function __construct(public ?Book $book = null, public ?int $id = null, public ?string $body = null)
     {
     }
 
+    public static function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = [])
+    {
+        $data->id = 0;
+
+        return $data;
+    }
+
     public static function getData(Operation $operation, array $uriVariables = [], array $context = []): object|array|null
     {
         return [