Revert "fix skipped data persisters on persist"

api-platform · Aug 22, 2018 · c211816 · c211816
1 parent 955b60f
commit c211816
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/DataPersister/ChainDataPersister.php b/src/DataPersister/ChainDataPersister.php
@@ -51,11 +51,9 @@ public function persist($data)
     {
         foreach ($this->persisters as $persister) {
             if ($persister->supports($data)) {
-                $data = $persister->persist($data) ?? $data;
+                return $persister->persist($data) ?? $data;
             }
         }
-
-        return $data;
     }
 
     /**

diff --git a/tests/DataPersister/ChainDataPersisterTest.php b/tests/DataPersister/ChainDataPersisterTest.php
@@ -60,15 +60,7 @@ public function testPersist()
         $barPersisterProphecy->supports($dummy)->willReturn(true)->shouldBeCalled();
         $barPersisterProphecy->persist($dummy)->shouldBeCalled();
 
-        $bazPersisterProphecy = $this->prophesize(DataPersisterInterface::class);
-        $bazPersisterProphecy->supports($dummy)->willReturn(true)->shouldBeCalled();
-        $bazPersisterProphecy->persist($dummy)->shouldBeCalled();
-
-        (new ChainDataPersister([
-            $fooPersisterProphecy->reveal(),
-            $barPersisterProphecy->reveal(),
-            $bazPersisterProphecy->reveal(),
-        ]))->persist($dummy);
+        (new ChainDataPersister([$fooPersisterProphecy->reveal(), $barPersisterProphecy->reveal()]))->persist($dummy);
     }
 
     public function testRemove()