Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for (#242): connectors not working brat json training issues #248

Merged

Conversation

percevalw
Copy link
Member

Description

This should mostly fix #242.

  • Fixes various errors in the docs
  • Add an explanation for BRAT boolean attributes issue
  • Makes edsnlp.data.write_json more verbose and smarter : when lines is left to None, it will now infer if the data should be written as a single JSONL file or as a directory of JSON files by default, based on the path argument being a file or not.

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (021f0c0) 96.70% compared to head (a68181c) 96.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files         255      255           
  Lines        8372     8379    +7     
=======================================
+ Hits         8096     8103    +7     
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw percevalw force-pushed the 242-connectors-not-working-brat-json-training-issues branch from 6e631f2 to 428c4e2 Compare January 8, 2024 20:09
@percevalw percevalw force-pushed the 242-connectors-not-working-brat-json-training-issues branch 5 times, most recently from 5931a2c to 0e61c6c Compare January 10, 2024 09:04
@percevalw percevalw force-pushed the 242-connectors-not-working-brat-json-training-issues branch from 0e61c6c to a68181c Compare January 10, 2024 17:13
@percevalw percevalw merged commit db532d4 into master Jan 10, 2024
10 checks passed
@percevalw percevalw deleted the 242-connectors-not-working-brat-json-training-issues branch November 14, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connectors not working [brat, json] & training issues
1 participant