-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored into MVC pattern. Added support for SyncFusion widgets. … #5
base: master
Are you sure you want to change the base?
Conversation
…anged naming conventions to C# style. Incremented demo to 0.1.0.0. Implemented RubberDuck folder comments.
I also removed the not-referenced MD5 library |
Hi. |
I would love some help getting this code working on my local machine. I think this is a great idea to make access more modern looking. |
I'm in a rush now, but I would be happy to help you. I will make some YouTube video to help people with the code |
That would be amazing I would really like that thank you keep me updated. |
Sure Alain. Btw, my name is Scott. Also, I elected to go with C# naming conventions because even though I learned OOP in VBA initially, I'm a full stack C# developer now and have learned to dislike Hungarian notation. So, mostly I just got rid of prefixes, and any public member starts with a Capital letter, and any private member, lower case. I tried to be thorough but I admit, I might have missed a few... I also got rid of the Updater and MD5 code because those weren't referenced anywhere in the rest of the project. My aim was to make HandleView a stand-alone importable library. I did keep the JSON converter code though because I saw that's how you're passing route params around. Over all, I'm INCREDIBLY impressed with the clever ways you've managed to execute JS from VBA, VBA from JS, pass data around and intercept Submit buttons! You've really done some fantastic work here, my friend. All I wanted to do was inch the ball a little close to a library that I can use. Lastly, I used RubberDuckVBA's folder annotations to organize code into 'folders' in their Project Explorer. If you haven't seen that free add-in, I HIGHLY recommend you take a look. Well done and highly useful tools, including unit testing which I intend to backfit into xhv very soon. But, I agree with you, that is a lot of code to review. Would you prefer that I just rename my fork something like HandleView-MVC or some such instead? I don't expect you to have to crawl through all my code changes if you don't want to. I'm about to embark on a complete rewrite of an Access app that I have had in production since 2006 and have been beating my brains out to figure out how to put a modern UI on it - and you've done it! All I wanted to do with these code changes is to set it up in a pattern that I know very well (mvc) and contribute back to your project. Let me know if you'd rather I just keep my fork separate from yours. |
Alain,
I’ve pushed quite a few changes this week. Just wanted to circle back with you about PRs. Are you at all interested in my updates? If not, I’ll cancel the PR and not send you anything new. On the other hand, if you do want me to keep you updated, I’m glad to lean in with you. You’ve got a great thing started here and I don’t want to get too far out ahead of you so just let me know.
Just so you are aware, my fork has been getting some attention from other devs lately that want me to press on but I don’t want to steal your thunder here without at least checking in with you.
I’ve also started documenting via the Wiki. If you want those changes you are welcome to any of it.
Take care,
Scott
From: Alain Guerard <[email protected]>
Sent: Wednesday, February 10, 2021 7:09 AM
To: apguerard/HandleView-DevPreview <[email protected]>
Cc: Scott Reeves <[email protected]>; Author <[email protected]>
Subject: Re: [apguerard/HandleView-DevPreview] Refactored into MVC pattern. Added support for SyncFusion widgets. … (#5)
Hi.
That's a lot of code to review :)
Can you explain what is your point of view in refactoring into MVC pattern ?
Maybe we can chat about your orientation
Thanks
Alain
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACVCD6TJRBKYXY32773LWQTS6KHRNANCNFSM4XMHLNAQ>.
|
Hi Scott, You can contact me directly at [email protected] to continue the discussion about future plan. Thanks! |
…Changed naming conventions to C# style. Incremented demo to 0.1.0.0. Implemented RubberDuck folder comments. Fixed typos throughout source code.