-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed theme change from dark mode to light mode not working #4505
Merged
junedchhipa
merged 2 commits into
apexcharts:main
from
Sebastian-Webster:fix-theme-change
Jun 13, 2024
Merged
fix: fixed theme change from dark mode to light mode not working #4505
junedchhipa
merged 2 commits into
apexcharts:main
from
Sebastian-Webster:fix-theme-change
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedchhipa
approved these changes
Jun 13, 2024
This should not have been merged in as it breaks transparent completely. |
The transparent background issue has been fixed in #4542 |
This was referenced Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed chart theme change from dark mode to light mode not working
Changing a chart from dark mode to light mode with the options object wasn't working (example at https://github.com/Sebastian-Webster/apex-reproducible-example)
This pull request fixes that issue so dark mode charts can be changed to light mode successfully
Type of change
Checklist: