Simplification of setting mocks for Selectors and Domains #453
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync to latest version
…ories with setMock() method which doesn't require .sObjectType() to be mocked * Feature to allow simplifying how a Selector and/or Domain are being stubbed * To prevent forgetting to mocks.when() the method .sObjectType(), causing unexpected and undesired test method results (especially for juniors) * Additionally, this aligns nicely with setMock() for Services where the Interface method is provided * New approach is 100% backward compatible with a little hint for developers as reminder to mock the sObjectType()-method * Original code to mock a Domain class: mocks.startStubbing(); mocks.when( m_domLeads.sObjectType() ).thenReturn( Lead.SObjectType ); mocks.stopStubbing(); fflib.domain.setMock( m_domLeads ); * New code: fflib.domain.setMock( Lead.SObjectType, m_domLeads );
foxysolutions
changed the title
foxysolutions
changed the title
wimvelzeboer
approved these changes
Jun 9, 2023
|
@ImJohnMDaniel I've updated the branch to match master again, but not sure if that was the only reason why you assigned it back to me? Thanks! |
|
@foxysolutions -- you are all good. I routinely "assign" PRs to the person that opened it. Just waiting for reviews from other team members (who may actually be on PTO this week), so I ask for your patience. |
|
@afawcett @ImJohnMDaniel any review possible on this small change, to simplify how mocks are being set? It was already reviewed once, so pending for 2nd one. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-06-05: fflib_Application.cls: Extending Selector and Domain Factories with setMock() method which doesn't require .sObjectType() to be mocked
Application.domain.setMock( Lead.SObjectType, m_domLeads );This change is