Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to fflib_SObjectMocks.registerDirty(SObject, SObjectField, SObject) #415

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

janskola
Copy link

@janskola janskola commented Jun 23, 2022

Fix to registerDirty(SObject, SObjectField, SObject) method with relationship registration

  • allows correct verification using fflib_Match for all parameters
  • follows existing implementation of registerNew with relationship and registerRelationship

Other smaller formatting changes without affecting functionality

  • using Schema.SObjectField instead of Schema.sObjectField (Salesforce preferred name AFAIK)
  • readability improvements in formatting long lines, unified style
  • indentation fix for methods commitWork() and below

This change is Reviewable

@janskola janskola marked this pull request as ready for review June 23, 2022 21:31
@ImJohnMDaniel
Copy link
Contributor

@janskola -- thank you for the submission.

Since this PR is meant to fix somethings, before we proceed with the review, please open a corresponding issue outlining what the details are around this issue and how to reproduce it.

Thanks for the help.

cc: @stohn777 and @daveespo

@janskola
Copy link
Author

Thank you for pointing me in the right direction, I've opened issue #416 describing the misbehavior. This PR proposal is fixing the issue.

@janskola
Copy link
Author

Hello @ImJohnMDaniel,
I've probably done something wrong with this PR and/or associated issue #416, not mentioning you or I'm just impatient (forgive me for that). Issue #416 is created and I hope helps to understand and reproduce the issue. Is there anything I can help with to get this PR merged?
Thank you for all efforts on this great library.

@janskola janskola removed their assignment Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants