Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial steps to separate Opportunities into domain and trigger handler #27

Conversation

wimvelzeboer
Copy link
Contributor

@wimvelzeboer wimvelzeboer commented Dec 11, 2020

(Work in Progress)
Initial steps to separate Domain from TriggerHandler in Opportunities domain


This change is Reviewable

@ImJohnMDaniel
Copy link
Contributor

@wimvelzeboer -- Why was this PR closed?

@PeterLin888
Copy link
Contributor

PeterLin888 commented Mar 29, 2021

@ImJohnMDaniel
It seemed to me that @wimvelzeboer has created #31 which may replace this PR when testing is passed. After that you may want to update the link from #27 to #31 on apex-enterprise-patterns/fflib-apex-common#323 .

@wimvelzeboer
Copy link
Contributor Author

@ImJohnMDaniel yeah, I am working on a new PR. That one has a few commits that are more clear.
I am still trying to find the best way of implementing it, as there is a big difference in interface structure of these examples compared to the examples in Andrews book "Force.com Enterprise Architecutre". Here the domains have interfaces starting with an 'I' while Andrews domains don't.. Can you please advise what is the best approach?

@PeterLin888
Copy link
Contributor

PeterLin888 commented Mar 29, 2021

@afawcett I wonder whether you may have some minutes to look into #31 which was related to apex-enterprise-patterns/fflib-apex-common#323 .

I have implemented Service Layer, Domain (TriggerHandler part) Layer and Selector Layer in my org while learning from your excellent 3rd edition book and https://github.com/PacktPublishing/Salesforce-Lightning-Platform-Enterprise-Architecture-Third-Edition .

Now I am about to learn from #31 to implement the Domain (non-TriggerHandler) Layer.

Thanks again for your book and your work at https://github.com/apex-enterprise-patterns and force-di!

And thanks @wimvelzeboer and the AEP team for the apex-enterprise-patterns/fflib-apex-common#300 !

@ImJohnMDaniel
Copy link
Contributor

@ImJohnMDaniel yeah, I am working on a new PR. That one has a few commits that are more clear.
I am still trying to find the best way of implementing it, as there is a big difference in interface structure of these examples compared to the examples in Andrews book "Force.com Enterprise Architecutre". Here the domains have interfaces starting with an 'I' while Andrews domains don't.. Can you please advise what is the best approach?

@wimvelzeboer -- understood. Yeah, stay with the convention that you see in this project as well as the fflib-apex-common-samplecode project. When @afawcett wrote his book, he had to copy the Apex Common framework as it was then and make some minor adjustments. Later on we were able to standardize that work in this main repo. As you have noted, there are a few differences between Andy's book repo and this main one. If there is a specific example that you need input on, please just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants