Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Improve mixins type definitions #514

Merged
merged 1 commit into from
May 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions types/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { BaseChart } from './components'
import { ReactiveDataMixin, ReactivePropMixin } from './mixins'

declare module 'vue-chartjs' {
export function generateChart(chartId: string, chartType: string): any;
Expand All @@ -12,8 +13,8 @@ declare module 'vue-chartjs' {
export class Bubble extends BaseChart {}
export class Scatter extends BaseChart {}
export const mixins: {
reactiveData: any
reactiveProp: any
reactiveData: typeof ReactiveDataMixin
reactiveProp: typeof ReactivePropMixin
}
}

9 changes: 9 additions & 0 deletions types/mixins.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import Vue from 'vue'

export declare class ReactiveDataMixin extends Vue {
chartData: any;
}

export declare class ReactivePropMixin extends Vue {
readonly chartData: any;
}