Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/typescript #378

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Feature/typescript #378

merged 3 commits into from
Jul 16, 2018

Conversation

apertureless
Copy link
Owner

@apertureless apertureless commented Jun 20, 2018 •
edited
Loading

@lee-alderdice
Copy link

lee-alderdice commented Jun 21, 2018 •
edited
Loading

Just trying to verify using npm install from the PR. npm install --save apertureless/vue-charts#pull/378/head -- error message states I don't have the right permissions

Host key verification failed.
npm ERR! fatal: Could not read from remote repository.

@apertureless
Copy link
Owner Author

@lee-alderdice

try adding

"vue-chartjs": "git+ssh://[email protected]:apertureless/vue-chartjs.git#feature/typescript"

to your package.json under dependencies

@enkot
Copy link

enkot commented Jun 26, 2018

@apertureless
Please, add mixins to exported classes.

enkot added a commit to enkot/vue-chartjs that referenced this pull request Jul 2, 2018
@enkot
fix: typescript types for mixins (apertureless#378)
3c66ac1
@enkot enkot mentioned this pull request Jul 2, 2018
Merged
1 task
@enkot @apertureless
fix: typescript types for mixins (#378) (#384)
f21c9d8 
Added types for mixins (#378).

### Fix or Enhancement? 
- Fix

### Tests
- [x] All tests passed

### Environment
- OS: Ubuntu 18.04
- NPM Version: 5.6.0
@apertureless apertureless merged commit 184be5c into develop Jul 16, 2018
@apertureless apertureless added this to the 2.4.0 milestone Jul 16, 2018
@apertureless apertureless deleted the feature/typescript branch October 20, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enkot enkot enkot approved these changes

Assignees
No one assigned
Labels
⚡ feature
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@apertureless @lee-alderdice @enkot