Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor identical code #303

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Refactor identical code #303

merged 2 commits into from
Feb 2, 2018

Conversation

nickknissen
Copy link
Contributor

Enhancement

Extract identical code into a function. This will reduce the build size.

File Before After refactor
vue-chartjs.js 26.7 KB 15.9 KB
vue-chartjs.min.js 13 KB 7.49 KB
  • All tests passed

Environment

  • OS: Windows 10
  • NPM Version: 5.5.1

@apertureless apertureless self-requested a review January 31, 2018 09:22
@apertureless
Copy link
Owner

Nice one! Thanks! 🙏
Will take a deeper look today evening.

snl-thumbs-up-awesome-d2Z9QYzA2aidiWn6

@nickknissen
Copy link
Contributor Author

The same can be done for reactiveData.js and reactiveProps.js but thought that would belong in a separate pull request.

@apertureless apertureless merged commit 71b50df into apertureless:develop Feb 2, 2018
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apertureless apertureless apertureless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickknissen @apertureless