-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v3 #225
Merged
Merged
Feature/v3 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Juszczak <[email protected]>
Implements #182. The private chart instance is now in the vue.js data model. And can be accessed over `this.$data._chart` Updated unit tests
Codecov Report
@@ Coverage Diff @@
## develop #225 +/- ##
======================================
Coverage 100% 100%
======================================
Files 11 11
Lines 105 96 -9
======================================
- Hits 105 96 -9
|
* master: Spelling Fix inaccuracies in Russian translation Added French doc to config add bahasa indonesia docs did not translate the correct file... French translation for README.md β¨ Add dist files to repo π Release new version 2.8.7 Update peerDependencies β¬οΈ Update dependencies π Release new version 2.8.6 π Update CHANGELOG v2.8.5 Replace deepmerge with lodash.merge π Update CHANGELOG v2.8.4 π₯ Remove transform-object-assign β Add dependency deepmerge π Update CHANGELOG π Release new version 2.8.3 # Conflicts: # dist/vue-chartjs.full.js # dist/vue-chartjs.full.min.js # dist/vue-chartjs.js # dist/vue-chartjs.min.js # docs/config.js # package.json # yarn.lock
Add build and config folders to ignore
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π vue-chart.js v3
Finally version 3 of vue-chartjs is ready to π£ . We have some breaking changes, but they are easy to change!
β Removed
Vue.extend()
in the base components #201β Changed the private data from private instance to private data instance #182
β Updated
peerDependencies
vue & chart.jsπ₯ Breaking Changes!
π£ Component creation
In
v2
you were creating your own chart components by extending the base component like this:This was possible because the base components had a
export default Vue.extend({})
in it. Which creates a subclass of the vue ctor. vue docsBecause of this Vue needed to be included as a dependency and bundled into the package for the browser build.
This was causing a lot of confusing π and also some weird errors #216, #151 and some more problems like increased bundle size and duplicated dependencies for browser build.
π Chart instance
Like mentioned in #182 vue could possibly overwrite the private
_chart
variable as it is saved as an unprotected instance variable. Now it makes usage of vue's private data notation.β¬ π Upgrade Guide
π£ Component creation
Create your components now with either extends or mixins :
or
π Chart instance
Replace
this._chart
withthis.$data._chart