Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Issue0 #614

Closed
adin234 opened this issue May 7, 2020 · 11 comments
Closed

Typescript Issue0 #614

adin234 opened this issue May 7, 2020 · 11 comments

Comments

@adin234
Copy link
Contributor

adin234 commented May 7, 2020

Expected Behavior

No type script error

Actual Behavior

ERROR in /path/to/project/node_modules/vue-chartjs/types/components.d.ts
7:27 Cannot use namespace 'ChartData' as a type.
    5 | export declare class BaseChart extends Vue {
    6 |   addPlugin (plugin?: object): void
  > 7 |   renderChart (chartData: ChartData, options?: ChartOptions): void
      |                           ^
    8 | }
    9 |
ERROR in /path/to/project/node_modules/vue-chartjs/types/components.d.ts
7:48 Cannot use namespace 'ChartOptions' as a type.
    5 | export declare class BaseChart extends Vue {
    6 |   addPlugin (plugin?: object): void
  > 7 |   renderChart (chartData: ChartData, options?: ChartOptions): void
      |                                                ^
    8 | }
    9 |
ERROR in /path/to/project/node_modules/vue-chartjs/types/mixins.d.ts
5:14 Cannot use namespace 'ChartData' as a type.
    3 |
    4 | export declare class ReactiveDataMixin extends Vue {
  > 5 |   chartData: ChartData;
      |              ^
    6 | }
    7 |
    8 | export declare class ReactivePropMixin extends Vue {
ERROR in /path/to/project/node_modules/vue-chartjs/types/mixins.d.ts
9:23 Cannot use namespace 'ChartData' as a type.
     7 |
     8 | export declare class ReactivePropMixin extends Vue {
  >  9 |   readonly chartData: ChartData;
       |                       ^
    10 | }
    11 |

Environment

  • typescript version: 3.5.2
  • vue.js version: 2.6.6
  • vue-chart.js version: 3.5.0
  • yarn version: 1.22.4
@ProMasoud
Copy link

same here!

@adin234
Copy link
Contributor Author

adin234 commented May 23, 2020

@apertureless
Copy link
Owner

If you have a fix feel free to make a PR.
I am not using typescript, thus it is hard for me to support it.

@bartosz-brodzik
Copy link

How to make this error go away? I can't build app because of this

@adin234
Copy link
Contributor Author

adin234 commented Jun 16, 2020

@bartosz-brodzik a pr was created but it is still pending review so you can look into the fork i created in the meantime

@apertureless
Copy link
Owner

@adin234 I've added some mentions to the PR.

@adin234
Copy link
Contributor Author

adin234 commented Jun 16, 2020

@apertureless i see no comments in the pr it just says you self-requested a review

@apertureless
Copy link
Owner

Sorry, seems it was only visible to me 🙈

@apertureless
Copy link
Owner

@adin234 should be visible for you now.

@adin234
Copy link
Contributor Author

adin234 commented Jun 21, 2020

updated the pr

apertureless pushed a commit that referenced this issue Jun 21, 2020
@adin234
Copy link
Contributor Author

adin234 commented Jun 24, 2020

PR merged, closing the issue

@adin234 adin234 closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants