Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Emit events from mixins with essential info #382

Closed
mrin9 opened this issue Jun 28, 2018 · 0 comments · Fixed by #389 · May be fixed by cbrightly/pump-and-dump#4
Closed

Feature Request: Emit events from mixins with essential info #382

mrin9 opened this issue Jun 28, 2018 · 0 comments · Fixed by #389 · May be fixed by cbrightly/pump-and-dump#4
Assignees
@apertureless
Labels
☂ feature-request
Milestone
2.4.0

Comments

@mrin9
Copy link

mrin9 commented Jun 28, 2018 •
edited
Loading

Expected Behavior

I wanted to add some extra logic as and when the data changes, so I ended up adding my own watcher for chartData, I would like to avoid this and take advantage of the existing watcher, which is added by reactiveProp mixin.
can you emit events and provide some essential info such as are you rendering or updating,
oldData vs newData etc.
That way I can take advantage of the event and add my additional functinality

Environment

  • vue.js version: 2.5.16
  • vue-chart.js version: 3.3.2

In case it helps, my main requirement is to generate an HTML based legend using this.$data._chart.generateLegend() whenever the labels change
@apertureless apertureless added this to the 2.4.0 milestone Jul 16, 2018
@apertureless apertureless self-assigned this Jul 16, 2018
apertureless added a commit that referenced this issue Jul 16, 2018
@apertureless
feat(events): Add events to reactiveMixins
896cfd6 
This will resolve #382
@apertureless apertureless mentioned this issue Jul 16, 2018
Merged
2 tasks
apertureless added a commit that referenced this issue Aug 4, 2018
@apertureless
feat(events): Add events to reactiveMixins (#389)
67e8e4d 
* feat(events): Add events to reactiveMixins

This will resolve #382

* docs(reactive): Add events section to docs
@snyk-bot snyk-bot mentioned this issue Sep 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apertureless apertureless

Labels
☂ feature-request
Projects
None yet
Milestone
2.4.0
2 participants
@apertureless @mrin9