New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix params for getOrders method #21

Merged

apertureless merged 1 commit into apertureless:master from pvomhoff:master

Oct 3, 2017

pvomhoff commented Oct 3, 2017 •

edited

Loading

All parameters for getOrder like filter and skip are send via the query parameter.

The params parameter doesn't exist in the request module.
So the parameters was not working at all.
See: https://github.com/request/request/tree/v2.81.0#requestoptions-callback

I replaced the params with qs


          Fix params for getOrders

9904ee2

Owner

apertureless commented Oct 3, 2017

Hey @pvomhoff
Thanks for this one. To be honest, I never really used the params, so missed this out 😞

apertureless added the Hacktoberfest label

apertureless merged commit 70851b1 into apertureless:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels