Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SameSite cookies attribute #370

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Support SameSite cookies attribute #370

merged 1 commit into from
Feb 9, 2021

Conversation

blat
Copy link
Contributor

@blat blat commented Feb 9, 2021

CAS_CookieJar::parseCookieHeader fails when cookie header contains a SameSite attribute.

Current:
"set-cookie: foo=bar; SameSite=none;" is parsed as ['name' => 'SameSite', 'value' => 'none']

Expected:
['name' => 'foo', 'value' => 'bar', 'samesite' => 'none']

@jfritschi jfritschi merged commit c61efe1 into apereo:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants