Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect reference to catalog #332

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

NoyException
Copy link
Contributor

@NoyException NoyException commented Dec 27, 2024

Aim at addressing #317

@NoyException NoyException marked this pull request as ready for review December 27, 2024 08:18
catalog/provider.go Outdated Show resolved Hide resolved
catalog/connpool.go Outdated Show resolved Hide resolved
@TianyuZhang1214 TianyuZhang1214 changed the title fix: fix the incorrect reference to catalog fix: incorrect reference to catalog Dec 30, 2024
Copy link
Contributor

@TianyuZhang1214 TianyuZhang1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TianyuZhang1214 TianyuZhang1214 merged commit 2631948 into main Dec 31, 2024
14 checks passed
@NoyException NoyException deleted the noy/fix-catalog-inconsistency branch December 31, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants