fix: h-scale opsRequest validation considers replicas and shards limit #8834
+197
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yipeng1030
changed the title
apecloud-bot
added
pre-approve
leon-inf
reviewed
Jan 21, 2025
…30/kubeblocks into bugfix/improve_scalein_validate
yipeng1030
requested review from
JashBook,
ahjing99,
linghan-hub,
michelle-0808,
shanshanying,
ldming,
zjx20,
sophon-zt and
Y-Rookie
as code owners
github-actions
bot
added
size/XXL
apecloud-bot
added
pre-approve
github-actions
bot
added
size/L
yipeng1030
changed the title
yipeng1030
changed the title
wangyelei
reviewed
Feb 7, 2025
wangyelei
reviewed
Feb 7, 2025
apecloud-bot
added
pre-approve
wangyelei
approved these changes
Feb 8, 2025
leon-inf
reviewed
Feb 10, 2025
| minNum, maxNum := 0, 16384 | ||
| if comSpec.ComponentDef != "" { | ||
| compDef := &appsv1.ComponentDefinition{} | ||
| if err := cli.Get(ctx, client.ObjectKey{Name: comSpec.ComponentDef, Namespace: r.Namespace}, compDef); err != nil { |
There was a problem hiding this comment.
It should only be obtained when h-scale.
There was a problem hiding this comment.
this validate function is only called when h-scale
| minNum, maxNum := 0, 2048 | ||
| if spec.ShardingDef != "" { | ||
| shardingDef := &appsv1.ShardingDefinition{} | ||
| if err := cli.Get(ctx, types.NamespacedName{Name: spec.ShardingDef, Namespace: r.Namespace}, shardingDef); err != nil { |
zjx20
reviewed
Feb 11, 2025
apecloud-bot
added
pre-approve
apecloud-bot
added
pre-approve
apecloud-bot
added
pre-approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8737
add a validation rule that a opsRequest considers replicas and shards limit