Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support for switchover in the sharding component by specifying the componentObjectName of the shard #8791

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested a review from a team as a code owner January 10, 2025 10:04
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jan 10, 2025
@wangyelei wangyelei linked an issue Jan 10, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 44.59459% with 41 lines in your changes missing coverage. Please review.

Project coverage is 60.46%. Comparing base (ac3c0c8) to head (52286f7).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operations/switchover.go 53.22% 26 Missing and 3 partials ⚠️
apis/operations/v1alpha1/opsrequest_validation.go 0.00% 7 Missing ⚠️
apis/operations/v1alpha1/opsrequest_types.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8791      +/-   ##
==========================================
+ Coverage   60.27%   60.46%   +0.18%     
==========================================
  Files         381      381              
  Lines       46158    46402     +244     
==========================================
+ Hits        27823    28055     +232     
+ Misses      15673    15660      -13     
- Partials     2662     2687      +25     
Flag Coverage Δ
unittests 60.46% <44.59%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 13, 2025
@wangyelei wangyelei merged commit 1602bfb into main Jan 13, 2025
36 checks passed
@wangyelei wangyelei deleted the feature/support_switchover_for_shard_1.0 branch January 13, 2025 07:08
@github-actions github-actions bot added this to the Release 0.9.2 milestone Jan 13, 2025
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12742273659

apecloud-bot pushed a commit that referenced this pull request Jan 13, 2025
… the componentObjectName of the shard (#8791)

(cherry picked from commit 1602bfb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support switchover for sharding components
4 participants