Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move the cluster and component controllers to separate packages #8779

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Jan 9, 2025

No description provided.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 9, 2025
@leon-inf leon-inf force-pushed the support/refactor-cluster-component-controller branch from dec6a4e to 2c97ab1 Compare January 9, 2025 09:37
@leon-inf leon-inf marked this pull request as ready for review January 9, 2025 09:38
@leon-inf leon-inf requested review from Y-Rookie and a team as code owners January 9, 2025 09:38
@leon-inf leon-inf force-pushed the support/refactor-cluster-component-controller branch from 2c97ab1 to 7536097 Compare January 9, 2025 09:46
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 125 lines in your changes missing coverage. Please review.

Project coverage is 60.44%. Comparing base (47fdd7a) to head (f563d4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../apps/cluster/transformer_cluster_normalization.go 58.75% 64 Missing and 9 partials ⚠️
controllers/apps/cluster/utils.go 70.23% 23 Missing and 2 partials ⚠️
controllers/apps/component/utils.go 77.55% 7 Missing and 4 partials ⚠️
.../component/transformer_component_load_resources.go 40.00% 6 Missing and 3 partials ⚠️
controllers/apps/cluster/test_utils.go 88.88% 2 Missing and 1 partial ⚠️
controllers/apps/component/test_utils.go 88.88% 2 Missing and 1 partial ⚠️
...s/apps/component/transformer_component_deletion.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8779      +/-   ##
==========================================
- Coverage   60.50%   60.44%   -0.07%     
==========================================
  Files         378      381       +3     
  Lines       45988    46158     +170     
==========================================
+ Hits        27827    27899      +72     
- Misses      15512    15594      +82     
- Partials     2649     2665      +16     
Flag Coverage Δ
unittests 60.44% <68.75%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf force-pushed the support/refactor-cluster-component-controller branch from 7536097 to a3756a1 Compare January 9, 2025 10:04
@leon-inf leon-inf force-pushed the support/refactor-cluster-component-controller branch from a3756a1 to 7480ad8 Compare January 9, 2025 10:06
@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 10, 2025
@leon-inf leon-inf merged commit ac3c0c8 into main Jan 10, 2025
35 checks passed
@leon-inf leon-inf deleted the support/refactor-cluster-component-controller branch January 10, 2025 07:01
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.2 milestone Jan 10, 2025
@leon-inf leon-inf modified the milestones: Release 0.9.2, Release 1.0.0 Jan 10, 2025
@apecloud-bot
Copy link
Collaborator

🤖 says: Error cherry-picking.

Auto-merging controllers/apps/cluster/transformer_cluster_backup_policy.go
Auto-merging controllers/apps/component/transformer_component_configuration.go
Auto-merging controllers/apps/componentversion_controller.go
CONFLICT (content): Merge conflict in controllers/apps/componentversion_controller.go
Auto-merging controllers/operations/opsrequest_controller_test.go
error: could not apply ac3c0c8... chore: move the cluster and component controllers to separate packages (#8779)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

@apecloud-bot
Copy link
Collaborator

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/12704849520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants