Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix create cluster with cd/cv failed when existing 0.9 kb #8755

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested review from leon-inf, Y-Rookie and a team as code owners January 7, 2025 02:29
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.64%. Comparing base (32de222) to head (d6266ec).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...trollers/apps/transformer_cluster_normalization.go 20.00% 6 Missing and 2 partials ⚠️
apis/apps/v1alpha1/conversion.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #8755    +/-   ##
========================================
  Coverage   60.64%   60.64%            
========================================
  Files         377      377            
  Lines       45615    45946   +331     
========================================
+ Hits        27665    27866   +201     
- Misses      15332    15438   +106     
- Partials     2618     2642    +24     
Flag Coverage Δ
unittests 60.64% <14.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjx20
Copy link
Contributor

zjx20 commented Jan 7, 2025

@leon-inf please take a look.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 7, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jan 8, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 8, 2025
@wangyelei wangyelei merged commit 87efae1 into main Jan 8, 2025
33 of 35 checks passed
@wangyelei wangyelei deleted the bugfix/dual_kb_bug branch January 8, 2025 02:59
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.2 milestone Jan 8, 2025
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12663246592

apecloud-bot pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants