Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the component controller is not notified when a backup for h-scale becomes ready #8473

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

leon-inf
Copy link
Contributor

fix #8469

@leon-inf leon-inf added this to the Release 1.0.0 milestone Nov 16, 2024
@leon-inf leon-inf requested review from Y-Rookie and a team as code owners November 16, 2024 11:55
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.21%. Comparing base (bc7dd2f) to head (f210a75).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
controllers/apps/transformer_component_workload.go 50.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8473      +/-   ##
==========================================
- Coverage   61.22%   61.21%   -0.02%     
==========================================
  Files         351      351              
  Lines       41854    41858       +4     
==========================================
- Hits        25624    25622       -2     
- Misses      13906    13919      +13     
+ Partials     2324     2317       -7     
Flag Coverage Δ
unittests 61.21% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 18, 2024
@leon-inf leon-inf merged commit 25ad8b1 into main Nov 18, 2024
41 checks passed
@leon-inf leon-inf deleted the bugfix/comp-not-notified-when-backup-ready branch November 18, 2024 09:14
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/11889439687

github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] apecloud-mysql scale-out failed, ITS replicas does not update.
4 participants