fix: config-related resource cannot be cleaned up after disable addons #8188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sophon-zt
commented
Sep 23, 2024
•
sophon-zt
commented
- fix [BUG] remove left-over configmaps used in config and scripts API after disabling Addons #8145
sophon-zt
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
Y-Rookie
as code owners
sophon-zt
force-pushed
the
bugfix/remove-left-over-configmaps-used-in-config-and-scripts-api-after-disabling-addons-issue8145
branch
from
d74cbe3 to
6af0f02
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.9 #8188 +/- ##
===============================================
+ Coverage 64.97% 65.20% +0.22%
===============================================
Files 358 358
Lines 45087 45201 +114
===============================================
+ Hits 29297 29473 +176
+ Misses 13179 13119 -60
+ Partials 2611 2609 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shanshanying
approved these changes
Sep 24, 2024
shanshanying
changed the title
zjx20
approved these changes
Sep 24, 2024
wangyelei
approved these changes
Sep 25, 2024
sophon-zt
deleted the
bugfix/remove-left-over-configmaps-used-in-config-and-scripts-api-after-disabling-addons-issue8145
branch
sophon-zt
added a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.