[BUG] make reviewable fails

[shanshanying]

According to the development guid

One should run make reviewable and make sure it success.

But on the latest main branch, it fails:

[infdahai]

It just seems to have an error with the type check.

[github-actions]

This issue has been marked as stale because it has been open for 30 days with no activity

[Jaxx4Fun]

@shanshanying Hi, I am interested in this issue. I found before the target reviewable is executed, it actually failed in generate stage..

Here is what I see after I run make generate

[shanshanying]

@shanshanying Hi, I am interested in this issue. I found before the target reviewable is executed, it actually failed in generate stage..

Here is what I see after I run make generate

which branch did you run make generate? could you pls sync the latest main branch and try it out? Thanks.

[Jaxx4Fun]

I have synced and ran make generate just now on the newest main branch and still got the same output...

The commit is bb2f7f6

I put some device info which may help.

go version
go version go1.22.0 darwin/arm64

sw_vers
ProductName:		macOS
ProductVersion:		14.3.1
BuildVersion:		23D60

[shanshanying]

I have synced and ran make generate just now on the newest main branch and still got the same output...

The commit is bb2f7f6

I put some device info which may help.

go version
go version go1.22.0 darwin/arm64

sw_vers
ProductName:		macOS
ProductVersion:		14.3.1
BuildVersion:		23D60

hi @Jaxx4Fun
what is your controller-gen version?
I am wandering it is a bug of controller-gen, pls check out the issue and find if it is relevant. kubernetes-sigs/controller-tools#888

BTW, this is the version I am working on:

./bin/controller-gen --version
Version: v0.12.1

In KubeBlocks, You can get it by

make controller-gen

[Jaxx4Fun]

I am wandering it is a bug of controller-gen, pls check out the issue and find if it is relevant. kubernetes-sigs/controller-tools#888

Yes. I just update the controller-gen to v0.14.0, which works for me currently. I can continue to work on this issue now..
Thanks! @shanshanying

[Jaxx4Fun]

Append test-go-generate to the dependency list of the target vet

I found the target reviewable depends on target vet, but simply running make vet it says

vet: pkg/configuration/container/container_kill_test.go:101:15: undefined: mocks.NewMockContainerAPIClient
which is generated in target test-go-generate.

Update EXCLUDES_DIRS in hack/license/header-check.sh

I found one of the excluded directory is set to pkg/lorry/component/. But currently there is no directory named component under pkg/lorry. According to the failure cases below, seems to exclude pkg/lorry/engines and pkg/lorry/util is enough, but I am not sure if it is too arbitrary. @shanshanying

Anyway I'd like to make a PR to fix these two issues first..

❯ make check-license-header |grep FAIL
Header check: pkg/lorry/engines/kafka/auth.go... FAIL
Header check: pkg/lorry/engines/kafka/consumer.go... FAIL
Header check: pkg/lorry/engines/kafka/kafka.go... FAIL
Header check: pkg/lorry/engines/kafka/metadata.go... FAIL
Header check: pkg/lorry/engines/kafka/metadata_test.go... FAIL
Header check: pkg/lorry/engines/kafka/producer.go... FAIL
Header check: pkg/lorry/engines/kafka/sarama_log_bridge.go... FAIL
Header check: pkg/lorry/engines/kafka/sasl_oauthbearer.go... FAIL
Header check: pkg/lorry/engines/kafka/scram_client.go... FAIL
Header check: pkg/lorry/engines/kafka/thirdparty/retry.go... FAIL
Header check: pkg/lorry/engines/kafka/utils.go... FAIL
Header check: pkg/lorry/engines/redis/metadata.go... FAIL
Header check: pkg/lorry/engines/redis/redis.go... FAIL
Header check: pkg/lorry/engines/redis/settings.go... FAIL
Header check: pkg/lorry/engines/redis/settings_test.go... FAIL
Header check: pkg/lorry/util/config/decode.go... FAIL
make: *** [check-license-header] Error 1