tests: fix ruff complaints and switch to bash

Signed-off-by: Paul Spooren <[email protected]>

asu/build.py

@@ -21,7 +21,6 @@
 from asu.package_changes import appy_package_changes
 
 log = logging.getLogger("rq.worker")
-log.setLevel(logging.DEBUG)
 
 
 def build(req: dict, job=None):

tests/conftest.py

@@ -5,7 +5,6 @@
 import prometheus_client
 import pytest
 from fakeredis import FakeStrictRedis
-from pytest import MonkeyPatch
 
 from asu.asu import create_app
 

tests/test_common.py

@@ -1,9 +1,21 @@
 import os
 import tempfile
-from os import getenv
-from pathlib import Path, PosixPath
+from pathlib import Path
 
-from asu.common import *
+from podman import PodmanClient
+
+from asu.common import (
+    check_manifest,
+    diff_packages,
+    fingerprint_pubkey_usign,
+    get_container_version_tag,
+    get_file_hash,
+    get_packages_hash,
+    get_request_hash,
+    get_str_hash,
+    run_container,
+    verify_usign,
+)
 
 
 def test_get_str_hash():
@@ -32,6 +44,8 @@ def test_get_request_hash():
         "package_hash": get_packages_hash(["test"]),
     }
 
+    assert get_request_hash(request) == "c4eb8bfd4bbd07d7cd2adf70d7ea02e4"
+
 
 def test_diff_packages():
     assert diff_packages({"test1"}, {"test1", "test2"}) == ["-test2", "test1"]
@@ -76,7 +90,7 @@ def test_get_version_container_tag():
 
 
 def test_check_manifest():
-    assert check_manifest({"test": "1.0"}, {"test": "1.0"}) == None
+    assert check_manifest({"test": "1.0"}, {"test": "1.0"}) is None
     assert (
         check_manifest({"test": "1.0"}, {"test": "2.0"})
         == "Impossible package selection: test version not as requested: 2.0 vs. 1.0"

tests/test_package_changes.py

@@ -1,5 +1,3 @@
-import pytest
-
 from asu.package_changes import appy_package_changes
 
 
@@ -52,6 +50,9 @@ def test_apply_package_changes_release():
     original_req = req.copy()
     appy_package_changes(req)
 
+    assert req == original_req
+
+
 def test_apply_package_changes_mediatek():
     req = {
         "version": "23.05",

tests/test_stats.py

@@ -1,6 +1,3 @@
-from prometheus_client import REGISTRY
-
-
 def test_stats_image_builds(client):
     response = client.post(
         "/api/v1/build",