Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6091] Drop support for Spark 3.2 #4834

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Sep 17, 2024

What is this PR for?

Follow the discussion in the mailing list, to drop support for Spark 3.2
https://www.mail-archive.com/[email protected]/msg37311.html

What type of PR is it?

Breaking change.

What is the Jira issue?

ZEPPELIN-6091

How should this be tested?

Pass CI

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? Yes.
  • Does this needs documentation? Yes, updated.

@@ -21,9 +21,9 @@ ENV MAVEN_OPTS="-Xms1024M -Xmx2048M -XX:MaxMetaspaceSize=1024m -XX:-UseGCOverhea
# Allow npm and bower to run with root privileges
RUN echo "unsafe-perm=true" > ~/.npmrc && \
echo '{ "allow_root": true }' > ~/.bowerrc && \
./mvnw -B package -DskipTests -Pbuild-distr -Pspark-3.3 -Pinclude-hadoop -Phadoop3 -Pspark-scala-2.12 -Pweb-classic -Pweb-dist && \
./mvnw -B package -DskipTests -Pbuild-distr -Pspark-3.4 -Pinclude-hadoop -Phadoop3 -Pspark-scala-2.12 -Pweb-classic -Pweb-dist && \
Copy link
Member Author

@pan3793 pan3793 Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, we use Spark 3.4 as the default version, it should be consistent everywhere.

<dependency>
<groupId>org.datanucleus</groupId>
<artifactId>datanucleus-core</artifactId>
<version>${datanucleus.core.version}</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to manage datanucleus explicitly, as it will be pulled by spark-hive automatically, all supported spark versions(3.3~3.5) depend on hive 2.3.9, thus depend on the same versions of datanucleus

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have cleaned up well.
LGTM

@pan3793 pan3793 merged commit ad79848 into apache:master Sep 19, 2024
28 checks passed
@pan3793
Copy link
Member Author

pan3793 commented Sep 19, 2024

Thanks, merged to master for 0.12

@pan3793 pan3793 deleted the ZEPPELIN-6091 branch September 20, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants