Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6080] Add support for bq single region dataset query #4815

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

meharanjan318
Copy link
Contributor

@meharanjan318 meharanjan318 commented Sep 6, 2024

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html

What type of PR is it?

Improvement
Please leave your type of PR only

Todos

  • - Task

What is the Jira issue?

How should this be tested?

*CI
local tests

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes

@meharanjan318 meharanjan318 changed the title Add support for bq single region dataset query [ZEPPELIN-6080] Add support for bq single region dataset query Sep 6, 2024
@meharanjan318
Copy link
Contributor Author

@pan3793 can you please take a look.

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate code should be avoided.

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, just small things

Reamer
Reamer previously approved these changes Sep 7, 2024
Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are looking good to me. Just the Pull request description should be updated.

jongyoul
jongyoul previously approved these changes Sep 8, 2024
Copy link
Member

@jongyoul jongyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the description @Reamer already mentioned.

@meharanjan318 meharanjan318 dismissed stale reviews from jongyoul and Reamer via 4d36db8 September 8, 2024 08:20
@meharanjan318
Copy link
Contributor Author

@Reamer @jongyoul updated the PR description and documentation file.

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meharanjan318
Copy link
Contributor Author

@Reamer can you please merge the PR as well if it looks good.

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Reamer Reamer merged commit 205014f into apache:master Sep 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants