[ZEPPELIN-1480] rework websocket sending to prevent partial frontend hangup #4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cked websockets due to multithreading
jongyoul
reviewed
Aug 25, 2024
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookSocket.java
Outdated
Show resolved
Hide resolved
also add debug logging to the class
johannesschillinger-dm
changed the title
johannesschillinger-dm
changed the title
|
@jongyoul thank you for your feedback - I reworked the PR. Our production system suffered heavily from frontend lockups due to this issue. With the proposed patch applied, Zeppelin remains stable. |
Reamer
requested changes
Sep 9, 2024
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookSocket.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookSocket.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookSocket.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public void send(String serializeMessage) throws IOException { | ||
| session.getBasicRemote().sendText(serializeMessage); | ||
| session.getAsyncRemote().sendText(serializeMessage, result -> { |
There was a problem hiding this comment.
This solution looks much better than the synchronize block
Reamer
requested changes
Sep 11, 2024
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookSocket.java
Outdated
Show resolved
Hide resolved
|
Nope. LGTM |
jongyoul
approved these changes
Sep 17, 2024
|
Thank you very much for your contribution. Hoping for more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Zeppelin Frontend sometimes stops working with following error in the log:
"Blocking message pending 10000 for BLOCKING"
According to Jetty documentation, Websocket writes need to be thread safe or the async functions need to be used.
This PR addresses the issue and makes the send requests thread safe
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1480
How should this be tested?
This problem only occurs in production size deployments and is inherently a race condition
Questions: