Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6038] Unification of the Logger variable #4793

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

ParkGyeongTae
Copy link
Contributor

@ParkGyeongTae ParkGyeongTae commented Aug 17, 2024

What is this PR for?

I discovered that the Logger variable differs across files. I want to standardize the Logger variable as "LOGGER" in all files. Please let me know if there are any additional parts that need to be addressed.

What type of PR is it?

Improvement

Todos

  • - log -> LOGGER
  • - LOG -> LOGGER
  • - logger -> LOGGER
  • - _LOGGER -> LOGGER

What is the Jira issue?

How should this be tested?

  • CI
  • Build and run the Zeppelin project

Screenshots (if appropriate)

240730_Logger

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

@Reamer
Copy link
Contributor

Reamer commented Aug 19, 2024

Please ensure that the logger is also private static final.

@ParkGyeongTae
Copy link
Contributor Author

@Reamer I have set all logger constants to private static final. Please review this.

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Found some minor issues and a major issue.
Files within zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/thrift must not be edited. These files are automatically generated.

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reamer Reamer merged commit 32f2a8e into apache:master Aug 26, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants