-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-6038] Unification of the Logger variable #4793
Conversation
Please ensure that the logger is also |
@Reamer I have set all logger constants to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Found some minor issues and a major issue.
Files within zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/thrift
must not be edited. These files are automatically generated.
file/src/test/java/org/apache/zeppelin/file/HDFSFileInterpreterTest.java
Outdated
Show resolved
Hide resolved
python/src/test/java/org/apache/zeppelin/python/PythonInterpreterPandasSqlTest.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
Show resolved
Hide resolved
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
I discovered that the Logger variable differs across files. I want to standardize the Logger variable as "LOGGER" in all files. Please let me know if there are any additional parts that need to be addressed.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: