[ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
force-pushed
the
python_requirement
branch
4 times, most recently
from
1811f25 to
98d637b
Compare
|
This kind of code, very related to the environnement, should be moved from java to a shell or python script. So this make easy to override and maitain it without recompiling all the java stuff. Or a new setting for disable it. |
Reamer
force-pushed
the
python_requirement
branch
from
98d637b to
7fcafe2
Compare
|
Yes you are probably right. I wrote this bugfix without rebuilding the existing verification to fix the bug quickly. |
zjffdu
reviewed
Sep 7, 2022
|
|
||
| import java.util.function.Predicate; | ||
|
|
||
| public class PythonPackagePredicate<T> implements Predicate<T> { |
zjffdu
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This pull request changes the Python dependency check minimally to get high flexibility for the package check.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Questions: