Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5804] support python 3.10 #4453

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

PrimWILL
Copy link
Contributor

@PrimWILL PrimWILL commented Aug 28, 2022

What is this PR for?

Change py4j version (0.10.7 -> 0.10.9.7) in python interpreter directory to support python 3.10

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5804

How should this be tested?

CI and manual (3.9 and 3.10)

Screenshots (if appropriate)

python3 10

Questions:

  • Does the licenses files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer
Copy link
Contributor

Reamer commented Sep 1, 2022

I think this should be tested via CI.

@PrimWILL
Copy link
Contributor Author

PrimWILL commented Sep 2, 2022

I think this should be tested via CI.

In CI, this already passed python 3.7 and python 3.8 tests . Do I have to add more python tests for 3.10 in CI?

@jongyoul
Copy link
Member

jongyoul commented Sep 5, 2022

I'll merge it if there's no further discussion

@Reamer
Copy link
Contributor

Reamer commented Sep 5, 2022

Do I have to add more python tests for 3.10 in CI?

Sooner or later we should also test with Python 3.10 in the CI setup. But this can be done in a separate pull request.

@PrimWILL
Copy link
Contributor Author

PrimWILL commented Sep 6, 2022

Sooner or later we should also test with Python 3.10 in the CI setup. But this can be done in a separate pull request.

Got it. Then I'll register related issue in jira.

@PrimWILL
Copy link
Contributor Author

PrimWILL commented Sep 6, 2022

Then I'll register related issue in jira.

You can see the issue in here.

@jongyoul jongyoul merged commit f42943c into apache:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants