[ZEPPELIN-5799] Enriched LdapRealm configuration in Shiro Authentication and fixed so… #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul8263
force-pushed
the
ZEPPELIN-5799
branch
from
95b8576 to
2f05bc1
Compare
paul8263
changed the title
…ion and fixed some wrong config items.
paul8263
force-pushed
the
ZEPPELIN-5799
branch
from
2f05bc1 to
fc42a51
Compare
jongyoul
approved these changes
Aug 16, 2022
|
Hi @jongyoul , Coul you please help rerun the tests? This PR is only for docs and leave those tests unchanged. They should not fail. Thanks. |
|
@paul8263 Yes, correct. I just would like to execute |
|
With this PR we have defined the same property twice. |
|
PR: #4447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me wrong config items.
What is this PR for?
Changed the configuration in LdapRealm example from
ldapRealm.contextFactory.systemAuthenticationMechanism=simpletoldapRealm.contextFactory.authenticationMechanism=simple.And enriched the explanation for
userSearchAttributeNameandmemberAttributeValueTemplate, which might be hard to understand before this PR.What type of PR is it?
Documentation
What is the Jira issue?
ZEPPELIN-5799
Questions: