Skip to content

Commit

Permalink
[ZEPPELIN-2105] yarn installed by frontend-maven-plugin causes build …
Browse files Browse the repository at this point in the history
…failure (BUG)

### What is this PR for?

yarn installed by frontend-maven-plugin causes build failure **when there is no nodeJS in local system**

To reproduce this bug

- Remove system nodejs
- Execute `mvn -X clean package -pl 'zeppelin-web' -DskipTests;`

#### Details.

- yarn installed by frontend-maven-plugin can't run commands described in scripts tag (`package.json`)
- it's due to yarn uses npm when run script tags.
- so we need to npm as well

#### See also

#2002
eirslett/frontend-maven-plugin#562

### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Rollback yarn to npm
* [x] - Update README.md for zeppelin-web

### What is the Jira issue?

[ZEPPELIN-2105](https://issues.apache.org/jira/browse/ZEPPELIN-2105)

### How should this be tested?

- Remove system nodejs
- `mvn -X clean package -pl 'zeppelin-web' -DskipTests;`

### Screenshots (if appropriate)

NONE

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <[email protected]>

Closes #2016 from 1ambda/ZEPPELIN-2105/rollback-yarn-to-npm and squashes the following commits:

c2affeb [1ambda] fix: Install npm as well

(cherry picked from commit 4fd85f7)
Signed-off-by: Lee moon soo <[email protected]>
  • Loading branch information
1ambda authored and Leemoonsoo committed Feb 21, 2017
1 parent 17fa705 commit b8ac535
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions zeppelin-web/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<properties>
<node.version>v6.9.1</node.version>
<yarn.version>v0.18.1</yarn.version>
<npm.version>4.2.0</npm.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!--plugin versions-->
Expand Down Expand Up @@ -110,10 +111,12 @@
<id>install node and yarn</id>
<goals>
<goal>install-node-and-yarn</goal>
<goal>install-node-and-npm</goal>
</goals>
<configuration>
<nodeVersion>${node.version}</nodeVersion>
<yarnVersion>${yarn.version}</yarnVersion>
<npmVersion>${npm.version}</npmVersion>
</configuration>
</execution>

Expand Down

0 comments on commit b8ac535

Please sign in to comment.