-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ZEPPELIN-6151] Remove AngularJS -> Angular Code Migration Suggestion…
… Feature ### What is this PR for? I propose removing the feature in Zeppelin's new UI that converts AngularJS code to Angular code. This feature currently prompts users when they run code with the `%angular` prefix, asking whether to migrate AngularJS code to Angular, and performs the migration if confirmed. The reasons for suggesting its removal are as follows: - The library supporting this feature is not compatible with the latest Angular versions due to peer dependency issues, making it difficult to upgrade Angular. - It is likely that this feature is not widely used by the community. Removing this feature will reduce unnecessary library dependencies, which will help streamline future updates to the latest Angular versions. If you have any other opinions, please feel free to share them. ### What type of PR is it? Removing Feature ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6151 ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4900 from tbonelee/remove-ng1-migration. Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit ae48f71) Signed-off-by: Cheng Pan <[email protected]>
- Loading branch information
Showing
8 changed files
with
11 additions
and
460 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 0 additions & 65 deletions
65
zeppelin-web-angular/src/app/services/ng-template-adapter.service.ts
This file was deleted.
Oops, something went wrong.
65 changes: 0 additions & 65 deletions
65
zeppelin-web-angular/src/app/share/ng1-migration/ng1-migration.component.html
This file was deleted.
Oops, something went wrong.
88 changes: 0 additions & 88 deletions
88
zeppelin-web-angular/src/app/share/ng1-migration/ng1-migration.component.less
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.