Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unity] Add dlight.gpu.Fallback in DispatchSortScan, add argsort, topk, and cumprod #16351

Merged
merged 5 commits into from
Jan 10, 2024
Merged

[Unity] Add dlight.gpu.Fallback in DispatchSortScan, add argsort, topk, and cumprod #16351

merged 5 commits into from
Jan 10, 2024

Conversation

yongwww
Copy link
Member

@yongwww yongwww commented Jan 5, 2024 •
edited
Loading

  • Add dlight.gpu.Fallback for cumsum/cumprod/topk on gpu in DispatchSortScan, it enables out-of-the-box execution.
  • Add argsort, topk, and cumprod into Relax

yongwww
yongwww commented Jan 5, 2024
View reviewed changes
Copy link
Member Author

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add more test cases tmr

python/tvm/relax/backend/dispatch_sort_scan.py Show resolved Hide resolved
@yongwww
Copy link
Member Author

yongwww commented Jan 5, 2024

ready for review. cc: @tqchen @jinhongyii @vinx13

@yongwww yongwww force-pushed the argsort_topk_cumprod branch from 62402fc to b2b95fb Compare January 6, 2024 03:24
@yongwww yongwww force-pushed the argsort_topk_cumprod branch from b2b95fb to 8ae815e Compare January 7, 2024 02:41
@tqchen tqchen requested a review from vinx13 January 8, 2024 17:09
tqchen
tqchen reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yongwww some minor comments and we are good to go

@tqchen tqchen merged commit e1d71b3 into apache:unity Jan 10, 2024
14 checks passed
@yongwww yongwww deleted the argsort_topk_cumprod branch January 10, 2024 22:34
@ysh329 ysh329 mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen left review comments

@vinx13 vinx13 Awaiting requested review from vinx13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yongwww @tqchen